Commit 4a2ff67c authored Oct 13, 2009 by Michael Tokarev Committed by Michal Marek Dec 12, 2009

kbuild: fix bzImage build for x86



As has been discussed previously (and Sam has been CC'ed), the fix
is still incorrect.  It replaces "echo -ne" with "/bin/echo -ne",
but neither of the two are guaranteed to support the necessary
arguments and necessary (hexadecimal) escape sequences.  What should
be used here is printf(1).  The trivial patch below (on top of these
kbuild changes) fixes this issue.

Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>

parent 053fe57a

scripts/Makefile.lib

+1 −1

Original line number	Diff line number	Diff line
		@@ -208,7 +208,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) \| gzip -f -9 > $@) \|\| \

		# Bzip2 and LZMA do not include size in file... so we have to fake that;
		# append the size as a 32-bit littleendian number as gzip does.
		size_append = /bin/echo -ne $(shell \
		size_append = printf $(shell \
		dec_size=0; \
		for F in $1; do \
		fsize=$$(stat -c "%s" $$F); \

Admin message