Commit 4a19fb11 authored Jul 23, 2009 by Stefan Bader Committed by Dave Kleikamp Jul 23, 2009

jfs: Fix early release of acl in jfs_get_acl

BugLink: http://bugs.launchpad.net/ubuntu/+bug/396780



Commit 073aaa1b "helpers for acl
caching + switch to those" introduced new helper functions for
acl handling but seems to have introduced a regression for jfs as
the acl is released before returning it to the caller, instead of
leaving this for the caller to do.
This causes the acl object to be used after freeing it, leading
to kernel panics in completely different places.

Thanks to Christophe Dumez for reporting and bisecting into this.

Reported-by: Christophe Dumez <dchris@gmail.com>
Tested-by: Christophe Dumez <dchris@gmail.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

parent 4be3bd78

fs/jfs/acl.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -67,10 +67,8 @@ static struct posix_acl jfs_get_acl(struct inode inode, int type)
		acl = posix_acl_from_xattr(value, size);
		}
		kfree(value);
		if (!IS_ERR(acl)) {
		if (!IS_ERR(acl))
		set_cached_acl(inode, type, acl);
		posix_acl_release(acl);
		}
		return acl;
		}

Admin message