scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() (4a109032) · Commits · 戴 / test

The three values starting at byte 8 of the Zoned Block Device Characteristics VPD page B6h are 32 bits values, not 64bits. So use get_unaligned_be32() to retrieve the values and not get_unaligned_be64() Fixes: ("sd: Implement support for ZBC devices") Cc: <stable@vger.kernel.org> Signed-off-by:

Damien Le Moal <damien.lemoal@wdc.com> Reviewed-by:

Bart Van Assche <Bart.VanAssche@wdc.com> Reviewed-by:

Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by:

Christoph Hellwig <hch@lst.de> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/sd_zbc.c

+3 −3

Original line number	Original line	Diff line number	Diff line
	@@ -423,15 +423,15 @@ static int sd_zbc_read_zoned_characteristics(struct scsi_disk *sdkp,
	if (sdkp->device->type != TYPE_ZBC) {		if (sdkp->device->type != TYPE_ZBC) {
	/* Host-aware */		/* Host-aware */
	sdkp->urswrz = 1;		sdkp->urswrz = 1;
	sdkp->zones_optimal_open = get_unaligned_be64(&buf[8]);		sdkp->zones_optimal_open = get_unaligned_be32(&buf[8]);
	sdkp->zones_optimal_nonseq = get_unaligned_be64(&buf[12]);		sdkp->zones_optimal_nonseq = get_unaligned_be32(&buf[12]);
	sdkp->zones_max_open = 0;		sdkp->zones_max_open = 0;
	} else {		} else {
	/* Host-managed */		/* Host-managed */
	sdkp->urswrz = buf[4] & 1;		sdkp->urswrz = buf[4] & 1;
	sdkp->zones_optimal_open = 0;		sdkp->zones_optimal_open = 0;
	sdkp->zones_optimal_nonseq = 0;		sdkp->zones_optimal_nonseq = 0;
	sdkp->zones_max_open = get_unaligned_be64(&buf[16]);		sdkp->zones_max_open = get_unaligned_be32(&buf[16]);
	}		}

	return 0;		return 0;

Admin message