Commit 4a00aa05 authored Aug 22, 2017 by Colin Ian King Committed by David S. Miller Aug 22, 2017

MIPS,bpf: fix missing break in switch statement



There is a missing break causing a fall-through and setting
ctx.use_bbit_insns to the wrong value. Fix this by adding the
missing break.

Detected with cppcheck:
"Variable 'ctx.use_bbit_insns' is reassigned a value before the old
one has been used. 'break;' missing?"

Fixes: 8d8d18c3 ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9695fe6f

arch/mips/net/ebpf_jit.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1892,6 +1892,7 @@ struct bpf_prog bpf_int_jit_compile(struct bpf_prog prog)
		case CPU_CAVIUM_OCTEON2:
		case CPU_CAVIUM_OCTEON3:
		ctx.use_bbit_insns = 1;
		break;
		default:
		ctx.use_bbit_insns = 0;
		}

Admin message