Commit 49f971bd authored May 28, 2019 by Huazhong Tan Committed by David S. Miller May 28, 2019

net: hns3: fix a memory leak issue for hclge_map_unmap_ring_to_vf_vector



When hclge_bind_ring_with_vector() fails,
hclge_map_unmap_ring_to_vf_vector() returns the error
directly, so nobody will free the memory allocated by
hclge_get_ring_chain_from_mbx().

So hclge_free_vector_ring_chain() should be called no matter
hclge_bind_ring_with_vector() fails or not.

Fixes: 84e095d6 ("net: hns3: Change PF to add ring-vect binding & resetQ to mailbox")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0d2f68c7

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -192,12 +192,10 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en,
		return ret;

		ret = hclge_bind_ring_with_vector(vport, vector_id, en, &ring_chain);
		if (ret)
		return ret;

		hclge_free_vector_ring_chain(&ring_chain);

		return 0;
		return ret;
		}

		static int hclge_set_vf_promisc_mode(struct hclge_vport *vport,

Admin message