Commit 49f1997a authored Jan 16, 2020 by YueHaibing Committed by Felipe Balbi Mar 15, 2020

usb: gadget: xudc: Remove redundant platform_get_irq error message



platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Acked-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent a415083a

drivers/usb/gadget/udc/tegra-xudc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
		}

		xudc->irq = platform_get_irq(pdev, 0);
		if (xudc->irq < 0) {
		dev_err(xudc->dev, "failed to get IRQ: %d\n",
		xudc->irq);
		if (xudc->irq < 0)
		return xudc->irq;
		}

		err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
		dev_name(&pdev->dev), xudc);

Admin message