Commit 49eef82d authored Jun 07, 2019 by Sebastian Andrzej Siewior Committed by David S. Miller Jun 09, 2019

tg3: Use napi_alloc_frag()

tg3_alloc_rx_data() uses netdev_alloc_frag() for skb allocation. All
callers of tg3_alloc_rx_data() either hold tp->lock (which is held with
BH disabled) or run in NAPI context.

Use napi_alloc_frag() for skb allocations.

Cc: Siva Reddy Kallam <siva.kallam@broadcom.com>
Cc: Prashant Sreedharan <prashant@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3a89aae4

drivers/net/ethernet/broadcom/tg3.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6710,7 +6710,7 @@ static int tg3_alloc_rx_data(struct tg3 tp, struct tg3_rx_prodring_set tpr,
		skb_size = SKB_DATA_ALIGN(data_size + TG3_RX_OFFSET(tp)) +
		SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
		if (skb_size <= PAGE_SIZE) {
		data = netdev_alloc_frag(skb_size);
		data = napi_alloc_frag(skb_size);
		*frag_size = skb_size;
		} else {
		data = kmalloc(skb_size, GFP_ATOMIC);

Admin message