Commit 49ed86f5 authored Aug 19, 2019 by Nishka Dasgupta Committed by Kevin Hilman Aug 20, 2019

soc: amlogic: meson-gx-socinfo: Add of_node_put() before return



The variable np in function meson_gx_socinfo_init takes the return value
of of_find_compatible_node, which gets a node but does not put it. If
this node is not put it may cause a memory leak. Hence put np after its
usefulness has been exhausted.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Fixes: a9daaba2 ("soc: Add Amlogic SoC Information driver")
Signed-off-by: Kevin Hilman <khilman@baylibre.com>

parent 62369971

drivers/soc/amlogic/meson-gx-socinfo.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -141,8 +141,10 @@ static int __init meson_gx_socinfo_init(void)
		}

		/* check if chip-id is available */
		if (!of_property_read_bool(np, "amlogic,has-chip-id"))
		if (!of_property_read_bool(np, "amlogic,has-chip-id")) {
		of_node_put(np);
		return -ENODEV;
		}

		/* node should be a syscon */
		regmap = syscon_node_to_regmap(np);

Admin message