Commit 49ce881c authored May 22, 2019 by Jisheng Zhang Committed by David S. Miller May 22, 2019

net: stmmac: fix reset gpio free missing



Commit 984203ce ("net: stmmac: mdio: remove reset gpio free")
removed the reset gpio free, when the driver is unbinded or rmmod,
we miss the gpio free.

This patch uses managed API to request the reset gpio, so that the
gpio could be freed properly.

Fixes: 984203ce ("net: stmmac: mdio: remove reset gpio free")
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ccfb62f2

drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -267,7 +267,8 @@ int stmmac_mdio_reset(struct mii_bus *bus)
		of_property_read_u32_array(np,
		"snps,reset-delays-us", data->delays, 3);

		if (gpio_request(data->reset_gpio, "mdio-reset"))
		if (devm_gpio_request(priv->device, data->reset_gpio,
		"mdio-reset"))
		return 0;
		}

Admin message