Commit 49c64df8 authored Mar 18, 2020 by Wen Yang Committed by Miquel Raynal Mar 24, 2020

mtd: phram: fix a double free issue in error path



The variable 'name' is released multiple times in the error path,
which may cause double free issues.
This problem is avoided by adding a goto label to release the memory
uniformly. And this change also makes the code a bit more cleaner.

Fixes: 4f678a58 ("mtd: fix memory leaks in phram_setup")
Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Cc: Joern Engel <joern@lazybastard.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200318153156.25612-1-wenyang@linux.alibaba.com

parent 4da0ea71

drivers/mtd/devices/phram.c

+9 −6

Original line number	Diff line number	Diff line
		@@ -243,22 +243,25 @@ static int phram_setup(const char *val)

		ret = parse_num64(&start, token[1]);
		if (ret) {
		kfree(name);
		parse_err("illegal start address\n");
		goto error;
		}

		ret = parse_num64(&len, token[2]);
		if (ret) {
		kfree(name);
		parse_err("illegal device length\n");
		goto error;
		}

		ret = register_device(name, start, len);
		if (!ret)
		if (ret)
		goto error;

		pr_info("%s device: %#llx at %#llx\n", name, len, start);
		else
		kfree(name);
		return 0;

		error:
		kfree(name);
		return ret;
		}

Admin message