Commit 49bd1a8f authored Aug 18, 2014 by Alexander Gordeev Committed by Christoph Hellwig Sep 16, 2014

hpsa: Fallback to MSI rather than to INTx if MSI-X failed



Currently the driver falls back to INTx mode when MSI-X
initialization failed. This is a suboptimal behaviour
for chips that also support MSI. This update changes that
behaviour and falls back to MSI mode in case MSI-X mode
initialization failed.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Acked-by: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: iss_storagedev@hp.com
Cc: linux-scsi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent ed81d774

drivers/scsi/hpsa.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -6176,7 +6176,6 @@ static void hpsa_interrupt_mode(struct ctlr_info *h)
		dev_warn(&h->pdev->dev, "MSI-X init failed %d\n",
		err);
		h->msix_vector = 0;
		goto default_int_mode;
		}
		}
		if (pci_find_capability(h->pdev, PCI_CAP_ID_MSI)) {

Admin message