Commit 4998f1ef authored by Jim Lin's avatar Jim Lin Committed by Greg Kroah-Hartman
Browse files

usb: Add devaddr in struct usb_device 



The Clear_TT_Buffer request sent to the hub includes the address of
the LS/FS child device in wValue field. usb_hub_clear_tt_buffer()
uses udev->devnum to set the address wValue. This won't work for
devices connected to xHC.

For other host controllers udev->devnum is the same as the address of
the usb device, chosen and set by usb core. With xHC the controller
hardware assigns the address, and won't be the same as devnum.

Here we add devaddr in "struct usb_device" for
usb_hub_clear_tt_buffer() to use.

Signed-off-by: default avatarJim Lin <jilin@nvidia.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32adeab3

drivers/usb/core/hub.c

+3 −1
Original line number Diff line number Diff line
@@ -873,7 +873,7 @@ int usb_hub_clear_tt_buffer(struct urb *urb) 
	/* info that CLEAR_TT_BUFFER needs */

	clear->tt = tt->multi ? udev->ttport : 1;

	clear->devinfo = usb_pipeendpoint (pipe);

	clear->devinfo |= udev->devnum << 4;

	clear->devinfo |= ((u16)udev->devaddr) << 4;

	clear->devinfo |= usb_pipecontrol(pipe)

			? (USB_ENDPOINT_XFER_CONTROL << 11)

			: (USB_ENDPOINT_XFER_BULK << 11);
@@ -2125,6 +2125,8 @@ static void update_devnum(struct usb_device *udev, int devnum) 
	/* The address for a WUSB device is managed by wusbcore. */

	if (!udev->wusb)

		udev->devnum = devnum;

	if (!udev->devaddr)

		udev->devaddr = (u8)devnum;

}



static void hub_free_dev(struct usb_device *udev)

drivers/usb/host/xhci.c

+2 −0
Original line number Diff line number Diff line
@@ -4125,6 +4125,8 @@ static int xhci_setup_device(struct usb_hcd *hcd, struct usb_device *udev, 
	/* Zero the input context control for later use */

	ctrl_ctx->add_flags = 0;

	ctrl_ctx->drop_flags = 0;

	slot_ctx = xhci_get_slot_ctx(xhci, virt_dev->out_ctx);

	udev->devaddr = (u8)(le32_to_cpu(slot_ctx->dev_state) & DEV_ADDR_MASK);



	xhci_dbg_trace(xhci, trace_xhci_dbg_address,

		       "Internal device address = %d",

include/linux/usb.h

+2 −0
Original line number Diff line number Diff line
@@ -578,6 +578,7 @@ struct usb3_lpm_parameters { 
 * @bus_mA: Current available from the bus

 * @portnum: parent port number (origin 1)

 * @level: number of USB hub ancestors

 * @devaddr: device address, XHCI: assigned by HW, others: same as devnum

 * @can_submit: URBs may be submitted

 * @persist_enabled:  USB_PERSIST enabled for this device

 * @have_langid: whether string_langid is valid
@@ -661,6 +662,7 @@ struct usb_device { 
	unsigned short bus_mA;

	u8 portnum;

	u8 level;

	u8 devaddr;



	unsigned can_submit:1;

	unsigned persist_enabled:1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE