Unverified Commit 49820944 authored Apr 22, 2019 by Jorge Ramirez-Ortiz Committed by Mark Brown May 03, 2019

regulator: core: simplify return value on suported_voltage



All the current clients of this API  assume that 0 corresponds
to a failure and non-zero to a pass therefore ignoring the need to
handle a negative error code.

This commit modifies the API to follow that standard since returning a
negative (EINVAL) doesn't seem to provide enough value to justify
the need to handle it.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent fd2f02f9

drivers/regulator/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3002,7 +3002,7 @@ EXPORT_SYMBOL_GPL(regulator_get_linear_step);
		* @min_uV: Minimum required voltage in uV.
		* @max_uV: Maximum required voltage in uV.
		*
		* Returns a boolean or a negative error code.
		* Returns a boolean.
		*/
		int regulator_is_supported_voltage(struct regulator *regulator,
		int min_uV, int max_uV)
		@@ -3026,7 +3026,7 @@ int regulator_is_supported_voltage(struct regulator *regulator,

		ret = regulator_count_voltages(regulator);
		if (ret < 0)
		return ret;
		return 0;
		voltages = ret;

		for (i = 0; i < voltages; i++) {

Admin message