Commit 497b4050 authored Jul 03, 2015 by Filipe Manana

Btrfs: fix memory leak in the extent_same ioctl



We were allocating memory with memdup_user() but we were never releasing
that memory. This affected pretty much every call to the ioctl, whether
it deduplicated extents or not.

This issue was reported on IRC by Julian Taylor and on the mailing list
by Marcel Ritter, credit goes to them for finding the issue.

Reported-by: Julian Taylor <jtaylor.debian@googlemail.com>
Reported-by: Marcel Ritter <ritter.marcel@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>

parent c1aa4575

fs/btrfs/ioctl.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3090,7 +3090,7 @@ out_unlock:
		static long btrfs_ioctl_file_extent_same(struct file *file,
		struct btrfs_ioctl_same_args __user *argp)
		{
		struct btrfs_ioctl_same_args *same;
		struct btrfs_ioctl_same_args *same = NULL;
		struct btrfs_ioctl_same_extent_info *info;
		struct inode *src = file_inode(file);
		u64 off;
		@@ -3120,6 +3120,7 @@ static long btrfs_ioctl_file_extent_same(struct file *file,

		if (IS_ERR(same)) {
		ret = PTR_ERR(same);
		same = NULL;
		goto out;
		}

		@@ -3190,6 +3191,7 @@ static long btrfs_ioctl_file_extent_same(struct file *file,

		out:
		mnt_drop_write_file(file);
		kfree(same);
		return ret;
		}

Admin message