Commit 495daef9 authored Sep 08, 2014 by Dan Carpenter Committed by Stefano Stabellini Sep 23, 2014

xen-scsiback: clean up a type issue in scsiback_make_tpg()



This code was confusing because we had an unsigned long and then we
compared it to UINT_MAX and then we stored it in a u16.  How many bytes
is this supposed to have: 2, 4 or 16???

I've made it a u16 throughout.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>

parent d9b1e637

drivers/xen/xen-scsiback.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1885,13 +1885,14 @@ scsiback_make_tpg(struct se_wwn *wwn,
		struct scsiback_tport, tport_wwn);

		struct scsiback_tpg *tpg;
		unsigned long tpgt;
		u16 tpgt;
		int ret;

		if (strstr(name, "tpgt_") != name)
		return ERR_PTR(-EINVAL);
		if (kstrtoul(name + 5, 10, &tpgt) \|\| tpgt > UINT_MAX)
		return ERR_PTR(-EINVAL);
		ret = kstrtou16(name + 5, 10, &tpgt);
		if (ret)
		return ERR_PTR(ret);

		tpg = kzalloc(sizeof(struct scsiback_tpg), GFP_KERNEL);
		if (!tpg)

Admin message