Commit 495b2176 authored Dec 11, 2014 by Alexandre Courbot Committed by Ben Skeggs Jan 22, 2015

drm/nouveau: sgdma: add comment around suspiscious error handler



Common programming sense dictates that resources allocated by a function
are freed by this function should it fails, but this is not the case for
the allocated structure of nouveau_sgdma_create_ttm(). It seems that
n00b contributors attempt to fix this one like bugs flying towards a bug
zapper, so add a comment to hopefully prevent this from happening
anymore.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 2474ae29

drivers/gpu/drm/nouveau/nouveau_sgdma.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -106,6 +106,11 @@ nouveau_sgdma_create_ttm(struct ttm_bo_device *bdev,
		nvbe->ttm.ttm.func = &nv50_sgdma_backend;

		if (ttm_dma_tt_init(&nvbe->ttm, bdev, size, page_flags, dummy_read_page))
		/*
		* A failing ttm_dma_tt_init() will call ttm_tt_destroy()
		* and thus our nouveau_sgdma_destroy() hook, so we don't need
		* to free nvbe here.
		*/
		return NULL;
		return &nvbe->ttm.ttm;
		}

Admin message