Commit 4954578e authored Oct 23, 2014 by nibble.max Committed by Mauro Carvalho Chehab Nov 03, 2014

[media] m88ts2022: return the err code in its probe function when error occurs

if "chip_id" is wrong or "dev->cfg.clock_out" is invalid, the i2c model is still loaded.
It will cause "kernel NULL pointer dereference" oops when the i2c model remove.
returning the err code will prevent the i2c model load.

Signed-off-by: Nibble Max <nibble.max@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 070e6661

drivers/media/tuners/m88ts2022.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -488,6 +488,7 @@ static int m88ts2022_probe(struct i2c_client *client,
		case 0x83:
		break;
		default:
		ret = -ENODEV;
		goto err;
		}

		@@ -505,6 +506,7 @@ static int m88ts2022_probe(struct i2c_client *client,
		u8tmp = 0x6c;
		break;
		default:
		ret = -EINVAL;
		goto err;
		}

Admin message