Commit 494fd7b7 authored by Feng Kan's avatar Feng Kan Committed by Rafael J. Wysocki
Browse files

PM / core: fix deferred probe breaking suspend resume order 



When bridge and its endpoint is enumerated the devices are added to the
dpm list. Afterward, the bridge defers probe when IOMMU is not ready.
This causes the bridge to be moved to the end of the dpm list when
deferred probe kicks in. The order of the dpm list for bridge and
endpoint is reversed.

Add reordering code to move the bridge and its children and consumers to
the end of the pm list so the order for suspend and resume is not altered.
The code also move device and its children and consumers to the tail of
device_kset list if it is registered.

Signed-off-by: default avatarToan Le <toanle@apm.com>
Signed-off-by: default avatarFeng Kan <fkan@apm.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 6d08b06e

drivers/base/base.h

+3 −0
Original line number Diff line number Diff line
@@ -161,3 +161,6 @@ extern void device_links_driver_cleanup(struct device *dev); 
extern void device_links_no_driver(struct device *dev);

extern bool device_links_busy(struct device *dev);

extern void device_links_unbind_consumers(struct device *dev);



/* device pm support */

void device_pm_move_to_tail(struct device *dev);

drivers/base/core.c

+20 −0
Original line number Diff line number Diff line
@@ -144,6 +144,26 @@ static int device_reorder_to_tail(struct device *dev, void *not_used) 
	return 0;

}



/**

 * device_pm_move_to_tail - Move set of devices to the end of device lists

 * @dev: Device to move

 *

 * This is a device_reorder_to_tail() wrapper taking the requisite locks.

 *

 * It moves the @dev along with all of its children and all of its consumers

 * to the ends of the device_kset and dpm_list, recursively.

 */

void device_pm_move_to_tail(struct device *dev)

{

	int idx;



	idx = device_links_read_lock();

	device_pm_lock();

	device_reorder_to_tail(dev, NULL);

	device_pm_unlock();

	device_links_read_unlock(idx);

}



/**

 * device_link_add - Create a link between two devices.

 * @consumer: Consumer end of the link.

drivers/base/dd.c

+1 −3
Original line number Diff line number Diff line
@@ -122,9 +122,7 @@ static void deferred_probe_work_func(struct work_struct *work) 
		 * the list is a good order for suspend but deferred

		 * probe makes that very unsafe.

		 */

		device_pm_lock();

		device_pm_move_last(dev);

		device_pm_unlock();

		device_pm_move_to_tail(dev);



		dev_dbg(dev, "Retrying from deferred list\n");

		if (initcall_debug && !initcalls_done)

CRA Git | Maintained and supported by SUSTech CRA and CCSE