Commit 49397b80 authored Mar 20, 2020 by Dan Carpenter Committed by Saeed Mahameed Mar 25, 2020

net/mlx5e: Fix actions_match_supported() return



The actions_match_supported() function returns a bool, true for success
and false for failure.  This error path is returning a negative which
is cast to true but it should return false.

Fixes: 4c3844d9 ("net/mlx5e: CT: Introduce connection tracking")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 29f3490b

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3057,7 +3057,7 @@ static bool actions_match_supported(struct mlx5e_priv *priv,
		*/
		NL_SET_ERR_MSG_MOD(extack,
		"Can't offload mirroring with action ct");
		return -EOPNOTSUPP;
		return false;
		}
		} else {
		actions = flow->nic_attr->action;

Admin message