Commit 4927f1fc authored Nov 05, 2015 by Jack Wang Committed by Martin K. Petersen Nov 09, 2015

isci: remove SCSI host before detaching from SAS transport

commit cff549e4 ("scsi: proper state checking and module refcount
handling in scsi_device_get") , the reference count of scsi device was
changed, which could lead to when rmmod with at least on drive attached,
SCSI error handle will run into infinite loop, and lockup the system.

Fix it by remove scsi host first, this way scsi core will not send
commands down after detaching SAS transport.

This is a follow up fix for Benjamin's fix for pm80xx.

See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html



Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ce664fb5

drivers/scsi/isci/init.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -272,11 +272,11 @@ static void isci_unregister(struct isci_host *isci_host)
		if (!isci_host)
		return;

		shost = to_shost(isci_host);
		scsi_remove_host(shost);
		sas_unregister_ha(&isci_host->sas_ha);

		shost = to_shost(isci_host);
		sas_remove_host(shost);
		scsi_remove_host(shost);
		scsi_host_put(shost);
		}

Admin message