Commit 48f67f54 authored Jan 22, 2009 by Rafael J. Wysocki Committed by Jesse Barnes Jan 27, 2009

PCI PM: Power up devices before restoring their state



Devices that have MSI-X enabled before suspend to RAM or hibernation
and that are in a low power state during resume will not be handled
correctly by pci_restore_standard_config().  Namely, it first calls
pci_restore_state() which calls pci_restore_msi_state(), which in turn
executes __pci_restore_msix_state() that accesses the device's memory
space to restore the contents of the MSI-X table.  However, if the
device is in a low power state at this point, it's memory space is
not accessible.

The easiest way to fix this potential problem is to make
pci_restore_standard_config() call pci_restore_state() after
it has put the device into the full power state, D0.  Fortunately,
all of this is done with interrupts off, so the change of ordering
should not cause any trouble.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent 545ffd58

drivers/pci/pci.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1393,12 +1393,11 @@ int pci_restore_standard_config(struct pci_dev *dev)
		pci_power_t prev_state;
		int error;

		pci_restore_state(dev);
		pci_update_current_state(dev, PCI_D0);

		prev_state = dev->current_state;
		if (prev_state == PCI_D0)
		return 0;
		goto Restore;

		error = pci_raw_set_power_state(dev, PCI_D0, false);
		if (error)
		@@ -1421,7 +1420,8 @@ int pci_restore_standard_config(struct pci_dev *dev)

		dev->current_state = PCI_D0;

		return 0;
		Restore:
		return pci_restore_state(dev);
		}

		/**

Admin message