Commit 48f5e749 authored Jun 05, 2019 by Hariprasad Kelam Committed by Felipe Balbi Jun 18, 2019

USB: omap_udc: Remove unneeded variable



With the current implementation omap_udc_stop is always
returning -ENODEV.

Added changes to return 0 and remove variable status.

Issue identified with coccicheck
drivers/usb/gadget/udc/omap_udc.c:2106:6-12:
Unneeded variable: "status". Return "- ENODEV" on line 2128

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 811e5c3d

drivers/usb/gadget/udc/omap_udc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2103,7 +2103,6 @@ done:
		static int omap_udc_stop(struct usb_gadget *g)
		{
		unsigned long flags;
		int status = -ENODEV;

		if (udc->dc_clk != NULL)
		omap_udc_enable_clock(1);
		@@ -2125,7 +2124,7 @@ static int omap_udc_stop(struct usb_gadget *g)
		if (udc->dc_clk != NULL)
		omap_udc_enable_clock(0);

		return status;
		return 0;
		}

		/-------------------------------------------------------------------------/

Admin message