Commit 48ebea50 authored Apr 24, 2020 by Luis Chamberlain Committed by Greg Kroah-Hartman Apr 28, 2020

firmware_loader: move fw_fallback_config to a private kernel symbol namespace

Take advantage of the new kernel symbol namespacing functionality, and
export the fw_fallback_config symbol only to a new private firmware loader
namespace. This would prevent misuses from other drivers and makes it clear
the goal is to keep this private to the firmware loader only.

It should also make it clearer for folks git grep'ing for users of
the symbol that this exported symbol is private, and prevent future
accidental removals of the exported symbol.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20200424184916.22843-2-mcgrof@kernel.org

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eb7fbc9f

drivers/base/firmware_loader/fallback.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -9,6 +9,7 @@
		#include <linux/umh.h>
		#include <linux/sysctl.h>
		#include <linux/vmalloc.h>
		#include <linux/module.h>

		#include "fallback.h"
		#include "firmware.h"
		@@ -17,6 +18,8 @@
		* firmware fallback mechanism
		*/

		MODULE_IMPORT_NS(FIRMWARE_LOADER_PRIVATE);

		extern struct firmware_fallback_config fw_fallback_config;

		/* These getters are vetted to use int properly */

drivers/base/firmware_loader/fallback_table.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -21,7 +21,7 @@ struct firmware_fallback_config fw_fallback_config = {
		.loading_timeout = 60,
		.old_timeout = 60,
		};
		EXPORT_SYMBOL_GPL(fw_fallback_config);
		EXPORT_SYMBOL_NS_GPL(fw_fallback_config, FIRMWARE_LOADER_PRIVATE);

		#ifdef CONFIG_SYSCTL
		struct ctl_table firmware_config_table[] = {

Admin message