Commit 48c6d121 authored Dec 22, 2012 by Eric W. Biederman

f2fs: Don't assign e_id in f2fs_acl_from_disk



With user namespaces enabled building f2fs fails with:

 CC      fs/f2fs/acl.o
fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
make[2]: *** [fs/f2fs/acl.o] Error 1
make[2]: Target `__build' not remade because of errors.

e_id is a backwards compatibility field only used for file systems
that haven't been converted to use kuids and kgids.  When the posix
acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
unnecessary.  Remove the assignment so f2fs will build with user
namespaces enabled.

Cc: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Amit Sahrawat <a.sahrawat@samsung.com>
Acked-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

parent dfb2ea45

fs/f2fs/acl.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -82,7 +82,6 @@ static struct posix_acl f2fs_acl_from_disk(const char value, size_t size)
	case ACL_GROUP_OBJ:		case ACL_GROUP_OBJ:
	case ACL_MASK:		case ACL_MASK:
	case ACL_OTHER:		case ACL_OTHER:
	acl->a_entries[i].e_id = ACL_UNDEFINED_ID;
	entry = (struct f2fs_acl_entry )((char )entry +		entry = (struct f2fs_acl_entry )((char )entry +
	sizeof(struct f2fs_acl_entry_short));		sizeof(struct f2fs_acl_entry_short));
	break;		break;

Admin message