Commit 48b45859 authored Sep 29, 2020 by Jing Xiangfeng Committed by Daniel Lezcano Oct 12, 2020

thermal: core: Adding missing nlmsg_free() in thermal_genl_sampling_temp()

thermal_genl_sampling_temp() misses to call nlmsg_free() in an error path.

Fixes: 1ce50e7d ("thermal: core: genetlink support for events/cmd/sampling")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200929082652.59876-1-jingxiangfeng@huawei.com

parent 5093402e

drivers/thermal/thermal_netlink.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -78,7 +78,7 @@ int thermal_genl_sampling_temp(int id, int temp)
		hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
		THERMAL_GENL_SAMPLING_TEMP);
		if (!hdr)
		return -EMSGSIZE;
		goto out_free;

		if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
		goto out_cancel;
		@@ -93,6 +93,7 @@ int thermal_genl_sampling_temp(int id, int temp)
		return 0;
		out_cancel:
		genlmsg_cancel(skb, hdr);
		out_free:
		nlmsg_free(skb);

		return -EMSGSIZE;