Commit 48af96ab authored Feb 15, 2017 by Brian Foster Committed by Darrick J. Wong Feb 16, 2017

xfs: don't reserve blocks for right shift transactions



The block reservation for the transaction allocated in
xfs_shift_file_space() is an artifact of the original collapse range
support. It exists to handle the case where a collapse range occurs,
the initial extent is left shifted into a location that forms a
contiguous boundary with the previous extent and thus the extents
are merged. This code was subsequently refactored and reused for
insert range (right shift) support.

If an insert range occurs under low free space conditions, the
extent at the starting offset is split before the first shift
transaction is allocated. If the block reservation fails, this
leaves separate, but contiguous extents around in the inode. While
not a fatal problem, this is unexpected and will flag a warning on
subsequent insert range operations on the inode. This problem has
been reproduce intermittently by generic/270 running against a
ramdisk device.

Since right shift does not create new extent boundaries in the
inode, a block reservation for extent merge is unnecessary. Update
xfs_shift_file_space() to conditionally reserve fs blocks for left
shift transactions only. This avoids the warning reproduced by
generic/270.

Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 353fe445

fs/xfs/xfs_bmap_util.c

+10 −10

Original line number	Diff line number	Diff line
		@@ -1385,10 +1385,16 @@ xfs_shift_file_space(
		xfs_fileoff_t stop_fsb;
		xfs_fileoff_t next_fsb;
		xfs_fileoff_t shift_fsb;
		uint resblks;

		ASSERT(direction == SHIFT_LEFT \|\| direction == SHIFT_RIGHT);

		if (direction == SHIFT_LEFT) {
		/*
		* Reserve blocks to cover potential extent merges after left
		* shift operations.
		*/
		resblks = XFS_DIOSTRAT_SPACE_RES(mp, 0);
		next_fsb = XFS_B_TO_FSB(mp, offset + len);
		stop_fsb = XFS_B_TO_FSB(mp, VFS_I(ip)->i_size);
		} else {
		@@ -1396,6 +1402,7 @@ xfs_shift_file_space(
		* If right shift, delegate the work of initialization of
		* next_fsb to xfs_bmap_shift_extent as it has ilock held.
		*/
		resblks = 0;
		next_fsb = NULLFSBLOCK;
		stop_fsb = XFS_B_TO_FSB(mp, offset);
		}
		@@ -1437,21 +1444,14 @@ xfs_shift_file_space(
		}

		while (!error && !done) {
		/*
		* We would need to reserve permanent block for transaction.
		* This will come into picture when after shifting extent into
		* hole we found that adjacent extents can be merged which
		* may lead to freeing of a block during record update.
		*/
		error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write,
		XFS_DIOSTRAT_SPACE_RES(mp, 0), 0, 0, &tp);
		error = xfs_trans_alloc(mp, &M_RES(mp)->tr_write, resblks, 0, 0,
		&tp);
		if (error)
		break;

		xfs_ilock(ip, XFS_ILOCK_EXCL);
		error = xfs_trans_reserve_quota(tp, mp, ip->i_udquot,
		ip->i_gdquot, ip->i_pdquot,
		XFS_DIOSTRAT_SPACE_RES(mp, 0), 0,
		ip->i_gdquot, ip->i_pdquot, resblks, 0,
		XFS_QMOPT_RES_REGBLKS);
		if (error)
		goto out_trans_cancel;

Admin message