Commit 489c25f9 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

selftests: mlxsw: Add rtnetlink tests 



Add a new test that is focused on rtnetlink configuration. Its purpose
is to test valid and invalid (as deemed by mlxsw) configurations and
make sure that they succeed / fail without producing a trace.

Some of the test cases are derived from recent fixes in order to make
sure that the fixed bugs are not introduced again.

Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b61cd7c6

tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh

+392 −0
Original line number Diff line number Diff line
@@ -13,9 +13,23 @@ ALL_TESTS=" 
	rif_set_addr_test

	rif_inherit_bridge_addr_test

	rif_non_inherit_bridge_addr_test

	vlan_interface_deletion_test

	bridge_deletion_test

	bridge_vlan_flags_test

	vlan_1_test

	lag_bridge_upper_test

	duplicate_vlans_test

	vlan_rif_refcount_test

	subport_rif_refcount_test

	vlan_dev_deletion_test

	lag_unlink_slaves_test

	lag_dev_deletion_test

	vlan_interface_uppers_test

	devlink_reload_test

"

NUM_NETIFS=2

source $lib_dir/lib.sh

source $lib_dir/devlink_lib.sh



setup_prepare()

{
@@ -160,6 +174,384 @@ rif_non_inherit_bridge_addr_test() 
	ip addr del dev $swp1 192.0.2.1/28

}



vlan_interface_deletion_test()

{

	# Test that when a VLAN interface is deleted, its associated router

	# interface (RIF) is correctly deleted and not leaked. See commit

	# c360867ec46a ("mlxsw: spectrum: Delete RIF when VLAN device is

	# removed") for more details

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0



	ip link add link br0 name br0.10 type vlan id 10

	ip -6 address add 2001:db8:1::1/64 dev br0.10

	ip link del dev br0.10



	# If we leaked the previous RIF, then this should produce a trace

	ip link add link br0 name br0.20 type vlan id 20

	ip -6 address add 2001:db8:1::1/64 dev br0.20

	ip link del dev br0.20



	log_test "vlan interface deletion"



	ip link del dev br0

}



bridge_deletion_test()

{

	# Test that when a bridge with VLAN interfaces is deleted, we correctly

	# delete the associated RIFs. See commit 602b74eda813 ("mlxsw:

	# spectrum_switchdev: Do not leak RIFs when removing bridge") for more

	# details

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0

	ip -6 address add 2001:db8::1/64 dev br0



	ip link add link br0 name br0.10 type vlan id 10

	ip -6 address add 2001:db8:1::1/64 dev br0.10



	ip link add link br0 name br0.20 type vlan id 20

	ip -6 address add 2001:db8:2::1/64 dev br0.20



	ip link del dev br0



	# If we leaked previous RIFs, then this should produce a trace

	ip -6 address add 2001:db8:1::1/64 dev $swp1

	ip -6 address del 2001:db8:1::1/64 dev $swp1



	log_test "bridge deletion"

}



bridge_vlan_flags_test()

{

	# Test that when bridge VLAN flags are toggled, we do not take

	# unnecessary references on related structs. See commit 9e25826ffc94

	# ("mlxsw: spectrum_switchdev: Fix port_vlan refcounting") for more

	# details

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0



	bridge vlan add vid 10 dev $swp1 pvid untagged

	bridge vlan add vid 10 dev $swp1 untagged

	bridge vlan add vid 10 dev $swp1 pvid

	bridge vlan add vid 10 dev $swp1

	ip link del dev br0



	# If we did not handle references correctly, then this should produce a

	# trace

	devlink dev reload "$DEVLINK_DEV"



	# Allow netdevices to be re-created following the reload

	sleep 20



	log_test "bridge vlan flags"

}



vlan_1_test()

{

	# Test that VLAN 1 cannot be configured, as it is used internally for

	# untagged traffic. See commit 47bf9df2e820 ("mlxsw: spectrum: Forbid

	# creation of VLAN 1 over port/LAG") for more details

	RET=0



	ip link add link $swp1 name $swp1.1 type vlan id 1 &> /dev/null

	check_fail $? "managed to create vlan 1 when should not"



	log_test "vlan 1"

}



lag_bridge_upper_test()

{

	# Test that ports cannot be enslaved to LAG devices that have uppers

	# and that failure is handled gracefully. See commit b3529af6bb0d

	# ("spectrum: Reference count VLAN entries") for more details

	RET=0



	ip link add name bond1 type bond mode 802.3ad



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev bond1 master br0



	ip link set dev $swp1 down

	ip link set dev $swp1 master bond1 &> /dev/null

	check_fail $? "managed to enslave port to lag when should not"



	# This might generate a trace, if we did not handle the failure

	# correctly

	ip -6 address add 2001:db8:1::1/64 dev $swp1

	ip -6 address del 2001:db8:1::1/64 dev $swp1



	log_test "lag with bridge upper"



	ip link del dev br0

	ip link del dev bond1

}



duplicate_vlans_test()

{

	# Test that on a given port a VLAN is only used once. Either as VLAN

	# in a VLAN-aware bridge or as a VLAN device

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0

	bridge vlan add vid 10 dev $swp1



	ip link add link $swp1 name $swp1.10 type vlan id 10 &> /dev/null

	check_fail $? "managed to create vlan device when should not"



	bridge vlan del vid 10 dev $swp1

	ip link add link $swp1 name $swp1.10 type vlan id 10

	check_err $? "did not manage to create vlan device when should"

	bridge vlan add vid 10 dev $swp1 &> /dev/null

	check_fail $? "managed to add bridge vlan when should not"



	log_test "duplicate vlans"



	ip link del dev $swp1.10

	ip link del dev br0

}



vlan_rif_refcount_test()

{

	# Test that RIFs representing VLAN interfaces are not affected from

	# ports member in the VLAN. We use the offload indication on routes

	# configured on the RIF to understand if it was created / destroyed

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0



	ip link set dev $swp1 up

	ip link set dev br0 up



	ip link add link br0 name br0.10 up type vlan id 10

	ip -6 address add 2001:db8:1::1/64 dev br0.10



	ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload

	check_err $? "vlan rif was not created before adding port to vlan"



	bridge vlan add vid 10 dev $swp1

	ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload

	check_err $? "vlan rif was destroyed after adding port to vlan"



	bridge vlan del vid 10 dev $swp1

	ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload

	check_err $? "vlan rif was destroyed after removing port from vlan"



	ip link set dev $swp1 nomaster

	ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload

	check_fail $? "vlan rif was not destroyed after unlinking port from bridge"



	log_test "vlan rif refcount"



	ip link del dev br0.10

	ip link set dev $swp1 down

	ip link del dev br0

}



subport_rif_refcount_test()

{

	# Test that RIFs representing upper devices of physical ports are

	# reference counted correctly and destroyed when should. We use the

	# offload indication on routes configured on the RIF to understand if

	# it was created / destroyed

	RET=0



	ip link add name bond1 type bond mode 802.3ad

	ip link set dev $swp1 down

	ip link set dev $swp2 down

	ip link set dev $swp1 master bond1

	ip link set dev $swp2 master bond1



	ip link set dev bond1 up

	ip link add link bond1 name bond1.10 up type vlan id 10

	ip -6 address add 2001:db8:1::1/64 dev bond1

	ip -6 address add 2001:db8:2::1/64 dev bond1.10



	ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload

	check_err $? "subport rif was not created on lag device"

	ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload

	check_err $? "subport rif was not created on vlan device"



	ip link set dev $swp1 nomaster

	ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload

	check_err $? "subport rif of lag device was destroyed when should not"

	ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload

	check_err $? "subport rif of vlan device was destroyed when should not"



	ip link set dev $swp2 nomaster

	ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload

	check_fail $? "subport rif of lag device was not destroyed when should"

	ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload

	check_fail $? "subport rif of vlan device was not destroyed when should"



	log_test "subport rif refcount"



	ip link del dev bond1.10

	ip link del dev bond1

}



vlan_dev_deletion_test()

{

	# Test that VLAN devices are correctly deleted / unlinked when enslaved

	# to bridge

	RET=0



	ip link add name br10 type bridge

	ip link add name br20 type bridge

	ip link add name br30 type bridge

	ip link add link $swp1 name $swp1.10 type vlan id 10

	ip link add link $swp1 name $swp1.20 type vlan id 20

	ip link add link $swp1 name $swp1.30 type vlan id 30

	ip link set dev $swp1.10 master br10

	ip link set dev $swp1.20 master br20

	ip link set dev $swp1.30 master br30



	# If we did not handle the situation correctly, then these operations

	# might produce a trace

	ip link set dev $swp1.30 nomaster

	ip link del dev $swp1.20

	# Deletion via ioctl uses different code paths from netlink

	vconfig rem $swp1.10 &> /dev/null



	log_test "vlan device deletion"



	ip link del dev $swp1.30

	ip link del dev br30

	ip link del dev br20

	ip link del dev br10

}



lag_create()

{

	ip link add name bond1 type bond mode 802.3ad

	ip link set dev $swp1 down

	ip link set dev $swp2 down

	ip link set dev $swp1 master bond1

	ip link set dev $swp2 master bond1



	ip link add link bond1 name bond1.10 type vlan id 10

	ip link add link bond1 name bond1.20 type vlan id 20



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev bond1 master br0



	ip link add name br10 type bridge

	ip link set dev bond1.10 master br10



	ip link add name br20 type bridge

	ip link set dev bond1.20 master br20

}



lag_unlink_slaves_test()

{

	# Test that ports are correctly unlinked from their LAG master, when

	# the LAG and its VLAN uppers are enslaved to bridges

	RET=0



	lag_create



	ip link set dev $swp1 nomaster

	check_err $? "lag slave $swp1 was not unlinked from master"

	ip link set dev $swp2 nomaster

	check_err $? "lag slave $swp2 was not unlinked from master"



	# Try to configure corresponding VLANs as router interfaces

	ip -6 address add 2001:db8:1::1/64 dev $swp1

	check_err $? "failed to configure ip address on $swp1"



	ip link add link $swp1 name $swp1.10 type vlan id 10

	ip -6 address add 2001:db8:10::1/64 dev $swp1.10

	check_err $? "failed to configure ip address on $swp1.10"



	ip link add link $swp1 name $swp1.20 type vlan id 20

	ip -6 address add 2001:db8:20::1/64 dev $swp1.20

	check_err $? "failed to configure ip address on $swp1.20"



	log_test "lag slaves unlinking"



	ip link del dev $swp1.20

	ip link del dev $swp1.10

	ip address flush dev $swp1



	ip link del dev br20

	ip link del dev br10

	ip link del dev br0

	ip link del dev bond1

}



lag_dev_deletion_test()

{

	# Test that LAG device is correctly deleted, when the LAG and its VLAN

	# uppers are enslaved to bridges

	RET=0



	lag_create



	ip link del dev bond1



	log_test "lag device deletion"



	ip link del dev br20

	ip link del dev br10

	ip link del dev br0

}



vlan_interface_uppers_test()

{

	# Test that uppers of a VLAN interface are correctly sanitized

	RET=0



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev $swp1 master br0



	ip link add link br0 name br0.10 type vlan id 10

	ip link add link br0.10 name macvlan0 \

		type macvlan mode private &> /dev/null

	check_fail $? "managed to create a macvlan when should not"



	ip -6 address add 2001:db8:1::1/64 dev br0.10

	ip link add link br0.10 name macvlan0 type macvlan mode private

	check_err $? "did not manage to create a macvlan when should"



	ip link del dev macvlan0



	ip link add name vrf-test type vrf table 10

	ip link set dev br0.10 master vrf-test

	check_err $? "did not manage to enslave vlan interface to vrf"

	ip link del dev vrf-test



	ip link add name br-test type bridge

	ip link set dev br0.10 master br-test &> /dev/null

	check_fail $? "managed to enslave vlan interface to bridge when should not"

	ip link del dev br-test



	log_test "vlan interface uppers"



	ip link del dev br0

}



devlink_reload_test()

{

	# Test that after executing all the above configuration tests, a

	# devlink reload can be performed without errors

	RET=0



	devlink dev reload "$DEVLINK_DEV"

	check_err $? "devlink reload failed"



	log_test "devlink reload - last test"



	sleep 20

}



trap cleanup EXIT



setup_prepare

CRA Git | Maintained and supported by SUSTech CRA and CCSE