Commit 4894fbcc authored May 09, 2019 by Cédric Le Goater Committed by Paul Mackerras May 14, 2019

KVM: PPC: Book3S: Remove useless checks in 'release' method of KVM device



There is no need to test for the device pointer validity when releasing
a KVM device. The file descriptor should identify it safely.

Fixes: 2bde9b3e ("KVM: Introduce a 'release' method for KVM devices")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>

parent 3f8cb76c

virt/kvm/kvm_main.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -2938,12 +2938,6 @@ static int kvm_device_release(struct inode inode, struct file filp)
		struct kvm_device *dev = filp->private_data;
		struct kvm *kvm = dev->kvm;

		if (!dev)
		return -ENODEV;

		if (dev->kvm != kvm)
		return -EPERM;

		if (dev->ops->release) {
		mutex_lock(&kvm->lock);
		list_del(&dev->vm_node);

Admin message