Commit 48679800 authored Oct 11, 2015 by Sowmini Varadhan Committed by David S. Miller Oct 13, 2015

RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.



The IP address passed to rds_bind() should be vetted by the
transport's ->laddr_check() for a previously bound transport.
This needs to be done to avoid cases where, for example,
the application has asked for an IB transport,
but the IP address passed to bind is only usable on
ethernet interfaces.

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 571f2c11

net/rds/bind.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -196,7 +196,14 @@ int rds_bind(struct socket sock, struct sockaddr uaddr, int addr_len)
		goto out;

		if (rs->rs_transport) { /* previously bound */
		trans = rs->rs_transport;
		if (trans->laddr_check(sock_net(sock->sk),
		sin->sin_addr.s_addr) != 0) {
		ret = -ENOPROTOOPT;
		rds_remove_bound(rs);
		} else {
		ret = 0;
		}
		goto out;
		}
		trans = rds_trans_get_preferred(sock_net(sock->sk),

Admin message