Commit 483c3191 authored Jan 13, 2014 by Mika Westerberg Committed by Mark Brown Jan 13, 2014

spi/pxa2xx: initialize DMA channels to -1 to prevent inadvertent match



Commit cddb339b (spi/pxa2xx: convert to dma_request_slave_channel_compat())
converted the driver to use ACPI provided DMA helpers but it forgot to
initialize the platform data for the channels to -1. Failing to do so will
result inadvertent match in the filter function because 0 is a valid
channel number.

Prevent this from happening by initializing both platform data channels
correctly to -1.

Fixes: cddb339b (spi/pxa2xx: convert to dma_request_slave_channel_compat())
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org

parent 6ce4eac1

drivers/spi/spi-pxa2xx.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1066,6 +1066,8 @@ pxa2xx_spi_acpi_get_pdata(struct platform_device *pdev)

		pdata->num_chipselect = 1;
		pdata->enable_dma = true;
		pdata->tx_chan_id = -1;
		pdata->rx_chan_id = -1;

		return pdata;
		}

Admin message