Commit 4831539d authored by Ilias Apalodimas's avatar Ilias Apalodimas Committed by David S. Miller
Browse files

net: netsec: remove superfluous if statement 



While freeing tx buffers the memory has to be unmapped if the packet was
an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid
of the unneeded extra 'else if' statement

Signed-off-by: default avatarIlias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c099a408

drivers/net/ethernet/socionext/netsec.c

+4 −4
Original line number Diff line number Diff line
@@ -654,12 +654,12 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv) 
		eop = (entry->attr >> NETSEC_TX_LAST) & 1;

		dma_rmb();



		if (desc->buf_type == TYPE_NETSEC_SKB)

		/* if buf_type is either TYPE_NETSEC_SKB or

		 * TYPE_NETSEC_XDP_NDO we mapped it

		 */

		if (desc->buf_type != TYPE_NETSEC_XDP_TX)

			dma_unmap_single(priv->dev, desc->dma_addr, desc->len,

					 DMA_TO_DEVICE);

		else if (desc->buf_type == TYPE_NETSEC_XDP_NDO)

			dma_unmap_single(priv->dev, desc->dma_addr,

					 desc->len, DMA_TO_DEVICE);



		if (!eop)

			goto next;

CRA Git | Maintained and supported by SUSTech CRA and CCSE