Commit 482e6dc5 authored by Josef Bacik's avatar Josef Bacik
Browse files

Btrfs: allow callers to specify if flushing can occur for btrfs_block_rsv_check 



If you run xfstest 224 it you will get lots of messages about not being able to
delete inodes and that they will be cleaned up next mount.  This is because
btrfs_block_rsv_check was not calling reserve_metadata_bytes with the ability to
flush, so if there was not enough space, it simply failed.  But in truncate and
evict case we could easily flush space to try and get enough space to do our
work, so make btrfs_block_rsv_check take a flush argument to pass down to
reserve_metadata_bytes.  Now xfstests 224 runs fine without all those
complaints.  Thanks,

Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
parent 07127184

fs/btrfs/ctree.h

+1 −1
Original line number Diff line number Diff line
@@ -2244,7 +2244,7 @@ int btrfs_block_rsv_add(struct btrfs_trans_handle *trans, 
int btrfs_block_rsv_check(struct btrfs_trans_handle *trans,

			  struct btrfs_root *root,

			  struct btrfs_block_rsv *block_rsv,

			  u64 min_reserved, int min_factor);

			  u64 min_reserved, int min_factor, int flush);

int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv,

			    struct btrfs_block_rsv *dst_rsv,

			    u64 num_bytes);

fs/btrfs/extent-tree.c

+2 −2
Original line number Diff line number Diff line
@@ -3705,7 +3705,7 @@ int btrfs_block_rsv_add(struct btrfs_trans_handle *trans, 
int btrfs_block_rsv_check(struct btrfs_trans_handle *trans,

			  struct btrfs_root *root,

			  struct btrfs_block_rsv *block_rsv,

			  u64 min_reserved, int min_factor)

			  u64 min_reserved, int min_factor, int flush)

{

	u64 num_bytes = 0;

	int ret = -ENOSPC;
@@ -3728,7 +3728,7 @@ int btrfs_block_rsv_check(struct btrfs_trans_handle *trans, 
	if (!ret)

		return 0;



	ret = reserve_metadata_bytes(trans, root, block_rsv, num_bytes, 0);

	ret = reserve_metadata_bytes(trans, root, block_rsv, num_bytes, flush);

	if (!ret) {

		block_rsv_add_bytes(block_rsv, num_bytes, 0);

		return 0;

fs/btrfs/free-space-cache.c

+1 −1
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ int btrfs_truncate_free_space_cache(struct btrfs_root *root, 
	trans->block_rsv = root->orphan_block_rsv;

	ret = btrfs_block_rsv_check(trans, root,

				    root->orphan_block_rsv,

				    0, 5);

				    0, 5, 0);

	if (ret)

		return ret;

fs/btrfs/inode.c

+3 −3
Original line number Diff line number Diff line
@@ -3576,10 +3576,10 @@ void btrfs_evict_inode(struct inode *inode) 
	 * doing the truncate.

	 */

	while (1) {

		ret = btrfs_block_rsv_check(NULL, root, rsv, min_size, 0);

		ret = btrfs_block_rsv_check(NULL, root, rsv, min_size, 0, 1);

		if (ret) {

			printk(KERN_WARNING "Could not get space for a "

			       "delete, will truncate on mount\n");

			       "delete, will truncate on mount %d\n", ret);

			btrfs_orphan_del(NULL, inode);

			btrfs_free_block_rsv(root, rsv);

			goto no_delete;
@@ -6575,7 +6575,7 @@ static int btrfs_truncate(struct inode *inode) 
		btrfs_add_ordered_operation(trans, root, inode);



	while (1) {

		ret = btrfs_block_rsv_check(trans, root, rsv, min_size, 0);

		ret = btrfs_block_rsv_check(trans, root, rsv, min_size, 0, 1);

		if (ret) {

			/*

			 * This can only happen with the original transaction we

fs/btrfs/relocation.c

+2 −2
Original line number Diff line number Diff line
@@ -2042,7 +2042,7 @@ static noinline_for_stack int merge_reloc_root(struct reloc_control *rc, 
		trans->block_rsv = rc->block_rsv;



		ret = btrfs_block_rsv_check(trans, root, rc->block_rsv,

					    min_reserved, 0);

					    min_reserved, 0, 0);

		if (ret) {

			BUG_ON(ret != -EAGAIN);

			ret = btrfs_commit_transaction(trans, root);
@@ -3775,7 +3775,7 @@ restart: 
		}



		ret = btrfs_block_rsv_check(trans, rc->extent_root,

					    rc->block_rsv, 0, 5);

					    rc->block_rsv, 0, 5, 0);

		if (ret < 0) {

			if (ret != -EAGAIN) {

				err = ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE