Unverified Commit 48279c53 authored Feb 12, 2018 by Sylwester Nawrocki Committed by Mark Brown Feb 14, 2018

ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access



It seems both PCLK_I2S1 and SCLK_I2S1 clocks need to be enabled before
I2S1 control registers can be accessed on exynos5433. If SCLK clock
is disabled an exception is triggered. To fix this parent clock of
the RCLK_SRC clock is assigned to pri_dai->op_clk so required gate
clock is handled by the runtime PM ops.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent aa274c5c

sound/soc/samsung/i2s.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -1404,9 +1404,14 @@ static int samsung_i2s_probe(struct platform_device *pdev)
		pm_runtime_enable(&pdev->dev);

		ret = i2s_register_clock_provider(pdev);
		if (!ret)
		if (ret < 0)
		goto err_disable_pm;

		pri_dai->op_clk = clk_get_parent(pri_dai->clk_table[CLK_I2S_RCLK_SRC]);

		return 0;

		err_disable_pm:
		pm_runtime_disable(&pdev->dev);
		err_disable_clk:
		clk_disable_unprepare(pri_dai->clk);

Admin message