Commit 481c5346 authored Jun 21, 2008 by Christoph Lameter Committed by Linus Torvalds Jun 21, 2008

Slab: Fix memory leak in fallback_alloc()



The zonelist patches caused the loop that checks for available
objects in permitted zones to not terminate immediately. One object
per zone per allocation may be allocated and then abandoned.

Break the loop when we have successfully allocated one object.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 62a8efe6

mm/slab.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -3263,9 +3263,12 @@ retry:

		if (cpuset_zone_allowed_hardwall(zone, flags) &&
		cache->nodelists[nid] &&
		cache->nodelists[nid]->free_objects)
		cache->nodelists[nid]->free_objects) {
		obj = ____cache_alloc_node(cache,
		flags \| GFP_THISNODE, nid);
		if (obj)
		break;
		}
		}

		if (!obj) {

Admin message