Unverified Commit 48118a93 authored Sep 11, 2019 by Peter Ujfalusi Committed by Mark Brown Sep 11, 2019

ASoC: dmaengine: Replace strncpy() with strscpy_pad() for pcm->name



While it is safe to use strncpy in this case, the advice is to move to
strscpy or strscpy_pad.

Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20190911083331.16801-1-peter.ujfalusi@ti.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 73681f4f

sound/soc/soc-generic-dmaengine-pcm.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -308,7 +308,7 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
		pcm->flags \|= SND_DMAENGINE_PCM_FLAG_NO_RESIDUE;

		if (rtd->pcm->streams[i].pcm->name[0] == '\0') {
		strncpy(rtd->pcm->streams[i].pcm->name,
		strscpy_pad(rtd->pcm->streams[i].pcm->name,
		rtd->pcm->streams[i].pcm->id,
		sizeof(rtd->pcm->streams[i].pcm->name));
		}

Admin message