Commit 47edc010 authored Nov 25, 2020 by Vinod Koul

soundwire: qcom: Fix build failure when slimbus is module



Commit 5bd77324 ("soundwire: qcom: avoid dependency on
CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but
it results in build failure when: CONFIG_SOUNDWIRE_QCOM=y
CONFIG_SLIMBUS=m

drivers/soundwire/qcom.o: In function `qcom_swrm_probe':
qcom.c:(.text+0xf44): undefined reference to `slimbus_bus'

Fix this by using IS_REACHABLE() in driver which is recommended to be
used with imply.

Fixes: 5bd77324 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS")
Reported-by: kernel test robot <lkp@intel.com>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Link: https://lore.kernel.org/r/20201125055155.GD8403@vkoul-mobl


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 47b85209

drivers/soundwire/qcom.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -799,7 +799,7 @@ static int qcom_swrm_probe(struct platform_device *pdev)
		data = of_device_get_match_data(dev);
		ctrl->rows_index = sdw_find_row_index(data->default_rows);
		ctrl->cols_index = sdw_find_col_index(data->default_cols);
		#if IS_ENABLED(CONFIG_SLIMBUS)
		#if IS_REACHABLE(CONFIG_SLIMBUS)
		if (dev->parent->bus == &slimbus_bus) {
		#else
		if (false) {

Admin message