Commit 47e81e59 authored Jul 10, 2017 by Ian Abbott Committed by Linus Torvalds Jul 10, 2017

linux/bug.h: correct "space required before that '-'"

Correct these checkpatch.pl errors:

|ERROR: space required before that '-' (ctx:OxO)
|#37: FILE: include/linux/bug.h:37:
|+#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))

|ERROR: space required before that '-' (ctx:OxO)
|#38: FILE: include/linux/bug.h:38:
|+#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))

I decided to wrap the bitfield expressions that begin with minus signs
in parentheses rather than insert spaces before the minus signs.

Link: http://lkml.kernel.org/r/20170525120316.24473-5-abbotti@mev.co.uk


Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8cdd7cca

include/linux/bug.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -36,8 +36,8 @@ struct pt_regs;
		* e.g. in a structure initializer (or where-ever else comma expressions
		* aren't permitted).
		*/
		#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
		#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))
		#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
		#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:(-!!(e)); }))

		/*
		* BUILD_BUG_ON_INVALID() permits the compiler to check the validity of the

Admin message