ASoC: cs35l35: Disable regulators on driver removal (47c4cc08) · Commits · 戴 / test

The chips main power supplies VA and VP are enabled during probe but then never disabled, this will cause warnings from the regulator framework on driver removal. Fix this by adding a remove callback and disabling the supplies, whilst doing so follow best practice and put the chip back into reset as well. Signed-off-by:

Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/codecs/cs35l35.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -1635,6 +1635,16 @@ err:
		return ret;
		}

		static int cs35l35_i2c_remove(struct i2c_client *i2c_client)
		{
		struct cs35l35_private *cs35l35 = i2c_get_clientdata(i2c_client);

		regulator_bulk_disable(cs35l35->num_supplies, cs35l35->supplies);
		gpiod_set_value_cansleep(cs35l35->reset_gpio, 0);

		return 0;
		}

		static const struct of_device_id cs35l35_of_match[] = {
		{.compatible = "cirrus,cs35l35"},
		{},
		@@ -1655,6 +1665,7 @@ static struct i2c_driver cs35l35_i2c_driver = {
		},
		.id_table = cs35l35_id,
		.probe = cs35l35_i2c_probe,
		.remove = cs35l35_i2c_remove,
		};

		module_i2c_driver(cs35l35_i2c_driver);

Admin message