Commit 47af1cdb authored Aug 25, 2017 by Colin Ian King Committed by Jiri Kosina Sep 06, 2017

HID: hid-lg: make array cbuf static const to shink object code size



Don't populate array cbuf on the stack, instead make it static.
Makes the object code smaller by over 110 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  15096	   3504	    128	  18728	   4928	drivers/hid/hid-lg.o

After:
   text	   data	    bss	    dec	    hex	filename
  14884	   3600	    128	  18612	   48b4	drivers/hid/hid-lg.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent b42a362e

drivers/hid/hid-lg.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -756,7 +756,9 @@ static int lg_probe(struct hid_device hdev, const struct hid_device_id id)

		/* Setup wireless link with Logitech Wii wheel */
		if (hdev->product == USB_DEVICE_ID_LOGITECH_WII_WHEEL) {
		const unsigned char cbuf[] = { 0x00, 0xAF, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
		static const unsigned char cbuf[] = {
		0x00, 0xAF, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
		};
		u8 *buf = kmemdup(cbuf, sizeof(cbuf), GFP_KERNEL);

		if (!buf) {

Admin message