Commit 47a39f61 authored Mar 26, 2020 by Jacob Keller Committed by David S. Miller Mar 26, 2020

devlink: use -ENOSPC to indicate no more room for snapshots



The devlink_region_snapshot_create function returns -ENOMEM when the
maximum number of snapshots has been reached. This is confusing because
it is not an issue of being out of memory. Change this to use -ENOSPC
instead.

Reported-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cf80faee

net/core/devlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3793,7 +3793,7 @@ __devlink_region_snapshot_create(struct devlink_region *region,

		/* check if region can hold one more snapshot */
		if (region->cur_snapshots == region->max_snapshots)
		return -ENOMEM;
		return -ENOSPC;

		if (devlink_region_snapshot_get_by_id(region, snapshot_id))
		return -EEXIST;

Admin message