Commit 479826cc authored Feb 12, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Feb 13, 2019

staging: comedi: ni_660x: fix missing break in switch statement



Add missing break statement in order to prevent the code from falling
through to the default case and return -EINVAL every time.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: aa94f288 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 277c8e8b

drivers/staging/comedi/drivers/ni_660x.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device *dev,
		case NI_660X_PFI_OUTPUT_DIO:
		if (chan > 31)
		return -EINVAL;
		break;
		default:
		return -EINVAL;
		}

Admin message