staging: fsl-dpaa2/ethsw: remove debug message (47980a20) · Commits · 戴 / test

Since ethtool will be loud enough if the .set_link_ksettings() callback fails, remove the debug messages which do not add additional information. Reported-by:

Andrew Lunn <andrew@lunn.ch> Signed-off-by:

Ioana Ciornei <ioana.ciornei@nxp.com> Link: https://lore.kernel.org/r/1565700187-16048-5-git-send-email-ioana.ciornei@nxp.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -91,8 +91,6 @@ ethsw_set_link_ksettings(struct net_device *netdev,
		struct dpsw_link_cfg cfg = {0};
		int err = 0;

		netdev_dbg(netdev, "Setting link parameters...");

		/* Due to a temporary MC limitation, the DPSW port must be down
		* in order to be able to change link settings. Taking steps to let
		* the user know that.
		@@ -116,11 +114,6 @@ ethsw_set_link_ksettings(struct net_device *netdev,
		port_priv->ethsw_data->dpsw_handle,
		port_priv->idx,
		&cfg);
		if (err)
		/* ethtool will be loud enough if we return an error; no point
		* in putting our own error message on the console by default
		*/
		netdev_dbg(netdev, "ERROR %d setting link cfg", err);

		return err;
		}

Admin message