Unverified Commit 478652f3 authored by Ryan Case's avatar Ryan Case Committed by Mark Brown
Browse files

spi: spi-qcom-qspi: Fix remaining driver nits



Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: default avatarRyan Case <ryandcase@chromium.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1fc12b05
Loading
Loading
Loading
Loading
+4 −4
Original line number Diff line number Diff line
@@ -90,6 +90,9 @@
#define PIO_DATAOUT_1B		0x0020
#define PIO_DATAOUT_4B		0x0024

#define RD_FIFO_CFG		0x0028
#define CONTINUOUS_MODE		BIT(0)

#define RD_FIFO_STATUS	0x002c
#define FIFO_EMPTY	BIT(11)
#define WR_CNTS_MSK	0x7f0
@@ -99,9 +102,6 @@
#define RDY_16BYTE	BIT(1)
#define FIFO_RDY	BIT(0)

#define RD_FIFO_CFG		0x0028
#define CONTINUOUS_MODE		BIT(0)

#define RD_FIFO_RESET		0x0030
#define RESET_FIFO		BIT(0)

@@ -139,7 +139,7 @@ struct qcom_qspi {
	struct device *dev;
	struct clk_bulk_data clks[QSPI_NUM_CLKS];
	struct qspi_xfer xfer;
	/* Lock to protect data accessed by IRQs */
	/* Lock to protect xfer and IRQ accessed registers */
	spinlock_t lock;
};