block/scsi_ioctl.c: quiet sparse noise (476d42f1) · Commits · 戴 / test

Quiet sparse noise about symbol's not being declared. Symbol blk_default_cmd_filter is only used locally and should be static. The function blk_scsi_ioctl_init() is a fs_initcall and should also be static. Signed-off-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Signed-off-by:

Jens Axboe <jens.axboe@oracle.com>

block/scsi_ioctl.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -35,7 +35,9 @@
		struct blk_cmd_filter {
		unsigned long read_ok[BLK_SCSI_CMD_PER_LONG];
		unsigned long write_ok[BLK_SCSI_CMD_PER_LONG];
		} blk_default_cmd_filter;
		};

		static struct blk_cmd_filter blk_default_cmd_filter;

		/* Command group 3 is reserved and should never be used. */
		const unsigned char scsi_command_size_tbl[8] =
		@@ -675,7 +677,7 @@ int scsi_cmd_ioctl(struct request_queue q, struct gendisk bd_disk, fmode_t mod
		}
		EXPORT_SYMBOL(scsi_cmd_ioctl);

		int __init blk_scsi_ioctl_init(void)
		static int __init blk_scsi_ioctl_init(void)
		{
		blk_set_cmd_filter_defaults(&blk_default_cmd_filter);
		return 0;

Admin message