Commit 475f9aa6 authored May 11, 2010 by Vitaly Mayatskikh Committed by Linus Torvalds May 11, 2010

kexec: fix OOPS in crash_kernel_shrink



Two "echo 0 > /sys/kernel/kexec_crash_size" OOPSes kernel.  Also content
of this file is invalid after first shrink to zero: it shows 1 instead of
0.

This scenario is unlikely to happen often (root privs, valid crashkernel=
in cmdline, dump-capture kernel not loaded), I hit it only by chance.

This patch fixes it.

Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: Cong Wang <amwang@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d586ebbb

kernel/kexec.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1134,10 +1134,8 @@ int crash_shrink_memory(unsigned long new_size)

		free_reserved_phys_range(end, crashk_res.end);

		if (start == end) {
		crashk_res.end = end;
		if (start == end)
		release_resource(&crashk_res);
		} else
		crashk_res.end = end - 1;

		unlock:

Admin message