Commit 474d2605 authored Oct 22, 2014 by Jan Kara

quota: Properly return errors from dquot_writeback_dquots()



Due to a switched left and right side of an assignment,
dquot_writeback_dquots() never returned error. This could result in
errors during quota writeback to not be reported to userspace properly.
Fix it.

CC: stable@vger.kernel.org
Coverity-id: 1226884
Signed-off-by: Jan Kara <jack@suse.cz>

parent 7938db44

fs/quota/dquot.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -634,7 +634,7 @@ int dquot_writeback_dquots(struct super_block *sb, int type)
		dqstats_inc(DQST_LOOKUPS);
		err = sb->dq_op->write_dquot(dquot);
		if (!ret && err)
		err = ret;
		ret = err;
		dqput(dquot);
		spin_lock(&dq_list_lock);
		}

Admin message