Commit 472c9e10 authored by Tobin C. Harding's avatar Tobin C. Harding
Browse files

leaking_addresses: skip all /proc/PID except /proc/1



When the system is idle it is likely that most files under /proc/PID
will be identical for various processes.  Scanning _all_ the PIDs under
/proc is unnecessary and implies that we are thoroughly scanning /proc.
This is _not_ the case because there may be ways userspace can trigger
creation of /proc files that leak addresses but were not present during
a scan.  For these two reasons we should exclude all PID directories
under /proc except '1/'

Exclude all /proc/PID except /proc/1.

Signed-off-by: default avatarTobin C. Harding <me@tobin.cc>
parent 5e4bac34
Loading
Loading
Loading
Loading
+12 −0
Original line number Original line Diff line number Diff line
@@ -10,6 +10,14 @@
# Use --debug to output path before parsing, this is useful to find files that
# Use --debug to output path before parsing, this is useful to find files that
# cause the script to choke.
# cause the script to choke.


#
# When the system is idle it is likely that most files under /proc/PID will be
# identical for various processes.  Scanning _all_ the PIDs under /proc is
# unnecessary and implies that we are thoroughly scanning /proc.  This is _not_
# the case because there may be ways userspace can trigger creation of /proc
# files that leak addresses but were not present during a scan.  For these two
# reasons we exclude all PID directories under /proc except '1/'

use warnings;
use warnings;
use strict;
use strict;
use POSIX;
use POSIX;
@@ -472,6 +480,10 @@ sub walk
			my $path = "$pwd/$file";
			my $path = "$pwd/$file";
			next if (-l $path);
			next if (-l $path);


			# skip /proc/PID except /proc/1
			next if (($path =~ /^\/proc\/[0-9]+$/) &&
				 ($path !~ /^\/proc\/1$/));

			next if (skip($path));
			next if (skip($path));


			if (-d $path) {
			if (-d $path) {