Commit 471af006 authored by Kim Phillips's avatar Kim Phillips Committed by Peter Zijlstra
Browse files

perf/x86/amd: Constrain Large Increment per Cycle events 



AMD Family 17h processors and above gain support for Large Increment
per Cycle events.  Unfortunately there is no CPUID or equivalent bit
that indicates whether the feature exists or not, so we continue to
determine eligibility based on a CPU family number comparison.

For Large Increment per Cycle events, we add a f17h-and-compatibles
get_event_constraints_f17h() that returns an even counter bitmask:
Large Increment per Cycle events can only be placed on PMCs 0, 2,
and 4 out of the currently available 0-5.  The only currently
public event that requires this feature to report valid counts
is PMCx003 "Retired SSE/AVX Operations".

Note that the CPU family logic in amd_core_pmu_init() is changed
so as to be able to selectively add initialization for features
available in ranges of backward-compatible CPU families.  This
Large Increment per Cycle feature is expected to be retained
in future families.

A side-effect of assigning a new get_constraints function for f17h
disables calling the old (prior to f15h) amd_get_event_constraints
implementation left enabled by commit e40ed154 ("perf/x86: Add perf
support for AMD family-17h processors"), which is no longer
necessary since those North Bridge event codes are obsoleted.

Also fix a spelling mistake whilst in the area (calulating ->
calculating).

Fixes: e40ed154 ("perf/x86: Add perf support for AMD family-17h processors")
Signed-off-by: default avatarKim Phillips <kim.phillips@amd.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20191114183720.19887-2-kim.phillips@amd.com
parent 1e0f1772

arch/x86/events/amd/core.c

+61 −30
Original line number Diff line number Diff line
@@ -301,6 +301,25 @@ static inline int amd_pmu_addr_offset(int index, bool eventsel) 
	return offset;

}



/*

 * AMD64 events are detected based on their event codes.

 */

static inline unsigned int amd_get_event_code(struct hw_perf_event *hwc)

{

	return ((hwc->config >> 24) & 0x0f00) | (hwc->config & 0x00ff);

}



static inline bool amd_is_pair_event_code(struct hw_perf_event *hwc)

{

	if (!(x86_pmu.flags & PMU_FL_PAIR))

		return false;



	switch (amd_get_event_code(hwc)) {

	case 0x003:	return true;	/* Retired SSE/AVX FLOPs */

	default:	return false;

	}

}



static int amd_core_hw_config(struct perf_event *event)

{

	if (event->attr.exclude_host && event->attr.exclude_guest)
@@ -319,14 +338,6 @@ static int amd_core_hw_config(struct perf_event *event) 
	return 0;

}



/*

 * AMD64 events are detected based on their event codes.

 */

static inline unsigned int amd_get_event_code(struct hw_perf_event *hwc)

{

	return ((hwc->config >> 24) & 0x0f00) | (hwc->config & 0x00ff);

}



static inline int amd_is_nb_event(struct hw_perf_event *hwc)

{

	return (hwc->config & 0xe0) == 0xe0;
@@ -855,6 +866,20 @@ amd_get_event_constraints_f15h(struct cpu_hw_events *cpuc, int idx, 
	}

}



static struct event_constraint pair_constraint;



static struct event_constraint *

amd_get_event_constraints_f17h(struct cpu_hw_events *cpuc, int idx,

			       struct perf_event *event)

{

	struct hw_perf_event *hwc = &event->hw;



	if (amd_is_pair_event_code(hwc))

		return &pair_constraint;



	return &unconstrained;

}



static ssize_t amd_event_sysfs_show(char *page, u64 config)

{

	u64 event = (config & ARCH_PERFMON_EVENTSEL_EVENT) |
@@ -898,33 +923,15 @@ static __initconst const struct x86_pmu amd_pmu = { 


static int __init amd_core_pmu_init(void)

{

	u64 even_ctr_mask = 0ULL;

	int i;



	if (!boot_cpu_has(X86_FEATURE_PERFCTR_CORE))

		return 0;



	/* Avoid calulating the value each time in the NMI handler */

	/* Avoid calculating the value each time in the NMI handler */

	perf_nmi_window = msecs_to_jiffies(100);



	switch (boot_cpu_data.x86) {

	case 0x15:

		pr_cont("Fam15h ");

		x86_pmu.get_event_constraints = amd_get_event_constraints_f15h;

		break;

	case 0x17:

		pr_cont("Fam17h ");

		/*

		 * In family 17h, there are no event constraints in the PMC hardware.

		 * We fallback to using default amd_get_event_constraints.

		 */

		break;

	case 0x18:

		pr_cont("Fam18h ");

		/* Using default amd_get_event_constraints. */

		break;

	default:

		pr_err("core perfctr but no constraints; unknown hardware!\n");

		return -ENODEV;

	}



	/*

	 * If core performance counter extensions exists, we must use

	 * MSR_F15H_PERF_CTL/MSR_F15H_PERF_CTR msrs. See also
@@ -939,6 +946,30 @@ static int __init amd_core_pmu_init(void) 
	 */

	x86_pmu.amd_nb_constraints = 0;



	if (boot_cpu_data.x86 == 0x15) {

		pr_cont("Fam15h ");

		x86_pmu.get_event_constraints = amd_get_event_constraints_f15h;

	}

	if (boot_cpu_data.x86 >= 0x17) {

		pr_cont("Fam17h+ ");

		/*

		 * Family 17h and compatibles have constraints for Large

		 * Increment per Cycle events: they may only be assigned an

		 * even numbered counter that has a consecutive adjacent odd

		 * numbered counter following it.

		 */

		for (i = 0; i < x86_pmu.num_counters - 1; i += 2)

			even_ctr_mask |= 1 << i;



		pair_constraint = (struct event_constraint)

				    __EVENT_CONSTRAINT(0, even_ctr_mask, 0,

				    x86_pmu.num_counters / 2, 0,

				    PERF_X86_EVENT_PAIR);



		x86_pmu.get_event_constraints = amd_get_event_constraints_f17h;

		x86_pmu.flags |= PMU_FL_PAIR;

	}



	pr_cont("core perfctr, ");

	return 0;

}

arch/x86/events/perf_event.h

+2 −0
Original line number Diff line number Diff line
@@ -77,6 +77,7 @@ static inline bool constraint_match(struct event_constraint *c, u64 ecode) 
#define PERF_X86_EVENT_AUTO_RELOAD	0x0200 /* use PEBS auto-reload */

#define PERF_X86_EVENT_LARGE_PEBS	0x0400 /* use large PEBS */

#define PERF_X86_EVENT_PEBS_VIA_PT	0x0800 /* use PT buffer for PEBS */

#define PERF_X86_EVENT_PAIR		0x1000 /* Large Increment per Cycle */



struct amd_nb {

	int nb_id;  /* NorthBridge id */
@@ -743,6 +744,7 @@ do { \ 
#define PMU_FL_EXCL_ENABLED	0x8 /* exclusive counter active */

#define PMU_FL_PEBS_ALL		0x10 /* all events are valid PEBS events */

#define PMU_FL_TFA		0x20 /* deal with TSX force abort */

#define PMU_FL_PAIR		0x40 /* merge counters for large incr. events */



#define EVENT_VAR(_id)  event_attr_##_id

#define EVENT_PTR(_id) &event_attr_##_id.attr.attr

CRA Git | Maintained and supported by SUSTech CRA and CCSE