Commit 46e85af0 authored Dec 13, 2020 by Dmitry Baryshkov Committed by Greg Kroah-Hartman Dec 13, 2020

driver core: platform: don't oops in platform_shutdown() on unbound devices

On shutdown the driver core calls the bus' shutdown callback also for
unbound devices. A driver's shutdown callback however is only called for
devices bound to this driver. Commit 9c30921f ("driver core:
platform: use bus_type functions") changed the platform bus from driver
callbacks to bus callbacks, so the shutdown function must be prepared to
be called without a driver. Add the corresponding check in the shutdown
function.

Fixes: 9c30921f ("driver core: platform: use bus_type functions")
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20201212235533.247537-1-dmitry.baryshkov@linaro.org

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2ab695aa

drivers/base/platform.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1351,9 +1351,13 @@ static int platform_remove(struct device *_dev)

		static void platform_shutdown(struct device *_dev)
		{
		struct platform_driver *drv = to_platform_driver(_dev->driver);
		struct platform_device *dev = to_platform_device(_dev);
		struct platform_driver *drv;

		if (!_dev->driver)
		return;

		drv = to_platform_driver(_dev->driver);
		if (drv->shutdown)
		drv->shutdown(dev);
		}