Commit 46e3cafb authored Jan 30, 2016 by Dan Carpenter Committed by Greg Kroah-Hartman Feb 03, 2016

USB: cxacru: fix an bounds check warning



This is a privileged operation so it doesn't matter much.  We use "tmp"
as an offset into an array.  If it were invalid we could read out of
bounds and trigger an oops if the memory is not mapped.  Plus it makes
static checkers complain.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1b83349f

drivers/usb/atm/cxacru.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -476,6 +476,8 @@ static ssize_t cxacru_sysfs_store_adsl_config(struct device *dev,
	return -EINVAL;		return -EINVAL;
	if (index < 0 \|\| index > 0x7f)		if (index < 0 \|\| index > 0x7f)
	return -EINVAL;		return -EINVAL;
			if (tmp < 0 \|\| tmp > len - pos)
			return -EINVAL;
	pos += tmp;		pos += tmp;

	/* skip trailing newline */		/* skip trailing newline */

Admin message